Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Random character deaths #2204

Open
ghost opened this issue Jun 10, 2023 · 15 comments
Open

[Bug] Random character deaths #2204

ghost opened this issue Jun 10, 2023 · 15 comments
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Jun 10, 2023

Posted in the server's development channel by XereniX:

This issue with Faruzan dying after using Elemental Burst is not exclusive to Faruzan herself
It also happens in following situations:
-Unleashing Yae Miko's Elemental Burst if any turrets are active (which means destroying turrets)
-Unleashing Gorou's Elemental Burst while General's War Banner (skill) is active (which means destroying the banner)
-Spawning new Albedo's flower while there is already one active
-The exact moment Faruzan's Elemental Burst duration expires (the moment Dazzling Polyhedron disappears)

@ghost ghost added the bug Something isn't working label Jun 10, 2023
@ImperadorSid
Copy link

The same occurs to me when Kaveh explodes Dendro Cores using his Elemental Skill

@KingRainbow44
Copy link
Member

these are normal things with the new ability system, the issues are mostly resource-related

@KingRainbow44 KingRainbow44 pinned this issue Jun 11, 2023
@ghost
Copy link
Author

ghost commented Jun 11, 2023

these are normal things with the new ability system

Characters randomly dying should not be considered normal.

the issues are mostly resource-related

Patching resources that were extracted from the game client is not a good idea unless there's something very bad with them, like missing important data or being unreadable. I don't think any other private servers have had the same issue with the same resources. Whatever happened to the activity handler that causes this is definitely a bug with GC itself.

@KingRainbow44
Copy link
Member

Patching resources that were extracted from the game client is not a good idea

i was more referencing the changes for KillSelf

Whatever happened to the activity handler

how are these related to the activity handler?

@ghost
Copy link
Author

ghost commented Jun 11, 2023

how are these related to the activity handler?

I meant ability system, my bad.

i was more referencing the changes for KillSelf

I don't know what this means.

@KingRainbow44
Copy link
Member

I don't know what this means.

the cause of the random avatar deaths is the KillSelf ability action handler, which is usually meant to be invoked on the gadgets which abilities spawn. the current resources have KillSelf over a previous action which killed the spawned gadget, making this a "resources issue"

@ghost
Copy link
Author

ghost commented Jun 11, 2023

Oh, I see. Thanks for the information.

@scooterboo
Copy link
Contributor

I had a similar problem in #2163 where some code was killing config.id 0 in a scene, which happens to be the player.

@scooterboo
Copy link
Contributor

A stack trace on the kill code (in player.java)? Might find where and why the player is being killed.

@StartForKiller
Copy link
Contributor

Okey, i pushed a fix for KillSelf a few hours ago, when magix merge it to developemtnt this should be fixed, but we need testing, because i'm working on 3.2

@KingRainbow44
Copy link
Member

can anyone confirm these bugs still occur?

@BurningFlareX
Copy link

I can confirm this issue is back in 4.0 and worse than ever.

My Layla randomly died while off-field and I can't even revive her. No revive sources work, including statue of the 7, food or /heal command.

Do not play without Godmode on right now.

@StartForKiller
Copy link
Contributor

StartForKiller commented Aug 29, 2023

I can confirm this issue is back in 4.0 and worse than ever.

My Layla randomly died while off-field and I can't even revive her. No revive sources work, including statue of the 7, food or /heal command.

Do not play without Godmode on right now.

Probably it's a resource problem. Make sure you have your resources set up correctly for 4.0.
And maybe the ability resources are incorrect for this version and needs to be fixed manually.

@BurningFlareX
Copy link

i downloaded the all-in-one install from Cultivation and didn't touch anything else afterwards.

@scooterboo
Copy link
Contributor

If you do a /pos in the location it happens, I might be able to help you.
Error codes would be nice too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants