Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend: Integrate RewriteAmpUrls transformer from AMP toolbox library #7158

Closed
swissspidy opened this issue Apr 8, 2021 · 0 comments · Fixed by #7186
Closed

Frontend: Integrate RewriteAmpUrls transformer from AMP toolbox library #7158

swissspidy opened this issue Apr 8, 2021 · 0 comments · Fixed by #7186
Labels
AMP Output Issues related to AMP output and validation P2 Should do soon Type: Enhancement New feature or improvement of an existing feature

Comments

@swissspidy
Copy link
Collaborator

Feature Description

We can improve frontend performance by leveraging the new AMP ES modules.

See ampproject/amp-wp#6037

We can implement Optimizer\Transformer\RewriteAmpUrls in our Optimization class.

Alternatives Considered

Additional Context

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

Implementation Brief
@swissspidy swissspidy added Type: Enhancement New feature or improvement of an existing feature P2 Should do soon AMP Output Issues related to AMP output and validation Pod: WP & Infra labels Apr 8, 2021
@swissspidy swissspidy mentioned this issue Apr 12, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
AMP Output Issues related to AMP output and validation P2 Should do soon Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

AMP Toolbox: ensure top-level resources folder is included GoogleForCreators/web-stories-wp
1 participant
@swissspidy