-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video - Options #441
Comments
WordPress it's supports added subtitle tracks and alternative version of file ( ogv, webm ). Should we also support these @swissspidy @pbakaus @jauyong ? |
Worth noting that gutenberg itself does not support subtitles ( WordPress/gutenberg#7673 ) or alternate sources ( WordPress/gutenberg#9457 ), at time of writing. |
Alternative versions: AMP Stories only support MP4, WEBM, HLS (docs), so this is a bit less relevant. I'd say we should just focus on MP4 for now. Other formats should be handled automatically by the editor in the future (WebAssembly, CDN, etc.) Subtitles: Perhaps at some point in the future, but not a P0 in my eyes. Even then we should ideally just automate it and hide it from users. Deferring to @pbakaus for making the decision though. |
I would say let's do MP4 and WEBM for now. Want to find out whether, and how we can support HLS in the future. /cc @newmuis |
We're in the midst of reevaluating what the best options are for video, but I don't think HLS makes the cut as a recommendation at this moment. We'll update the docs once this is finalized, but doing only WEBM/MP4 makes sense for now |
Hey @samitron7 is there a design for where the looping option shows? Or is it the same as Jonny's screenshot above? |
@pbakaus the brief for Media-specific controls is also missing as denoted by the red text in the Product Spec doc. |
@jauyong all related spec should be written. Note that there's a red "Panel:Video" in the spec, but we only really need that when we ship subsequent features not in v1. |
I couldn't find where looping was covered in the docs but since this is in code review I'd assume Jonny found it |
arrgh you're so right. The loop option was missing. Will add now. |
Alright, it can be found here: https://docs.google.com/document/d/1EQ12sD4a1plmMeBu7YMWOdUSg0FeegB9qi2_OlV3Tp0/edit#heading=h.h3uoy4bqqh92 |
Just realized that muting is deprecated in favor of using |
Feature Description
As an editor utilizing videos, I want to see what options are available for my videos
Waiting for Feature Brief
https://www.figma.com/file/Cd9iacVknHK62RO4pRwb68/Stories-Editor?node-id=2671%3A55920
Do not alter or remove anything below. The following sections will be managed by moderators only.
QA Instructions
The text was updated successfully, but these errors were encountered: