Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video - Options #441

Closed
jauyong opened this issue Mar 2, 2020 · 12 comments
Closed

Video - Options #441

jauyong opened this issue Mar 2, 2020 · 12 comments

Comments

@jauyong
Copy link

jauyong commented Mar 2, 2020

Feature Description

As an editor utilizing videos, I want to see what options are available for my videos

Waiting for Feature Brief

https://www.figma.com/file/Cd9iacVknHK62RO4pRwb68/Stories-Editor?node-id=2671%3A55920


Do not alter or remove anything below. The following sections will be managed by moderators only.

  1. The editor is presented with a looping option
  2. The editor is able to mute a video (the video will have no sound when played) (Note: Videos are muted in AMP)

QA Instructions

@spacedmonkey
Copy link
Contributor

image

image

WordPress it's supports added subtitle tracks and alternative version of file ( ogv, webm ). Should we also support these @swissspidy @pbakaus @jauyong ?

@spacedmonkey
Copy link
Contributor

Worth noting that gutenberg itself does not support subtitles ( WordPress/gutenberg#7673 ) or alternate sources ( WordPress/gutenberg#9457 ), at time of writing.

@swissspidy
Copy link
Collaborator

Alternative versions: AMP Stories only support MP4, WEBM, HLS (docs), so this is a bit less relevant. I'd say we should just focus on MP4 for now. Other formats should be handled automatically by the editor in the future (WebAssembly, CDN, etc.)

Subtitles: Perhaps at some point in the future, but not a P0 in my eyes. Even then we should ideally just automate it and hide it from users.

Deferring to @pbakaus for making the decision though.

@jauyong jauyong changed the title Video - Options Video - Looping Mar 4, 2020
@jauyong jauyong changed the title Video - Looping Video - Options Mar 4, 2020
@jauyong jauyong added the Size: S label Mar 4, 2020
@pbakaus
Copy link
Contributor

pbakaus commented Mar 7, 2020

Alternative versions: AMP Stories only support MP4, WEBM, HLS (docs), so this is a bit less relevant. I'd say we should just focus on MP4 for now. Other formats should be handled automatically by the editor in the future (WebAssembly, CDN, etc.)

Subtitles: Perhaps at some point in the future, but not a P0 in my eyes. Even then we should ideally just automate it and hide it from users.

Deferring to @pbakaus for making the decision though.

I would say let's do MP4 and WEBM for now. Want to find out whether, and how we can support HLS in the future. /cc @newmuis

@newmuis
Copy link

newmuis commented Mar 7, 2020

We're in the midst of reevaluating what the best options are for video, but I don't think HLS makes the cut as a recommendation at this moment. We'll update the docs once this is finalized, but doing only WEBM/MP4 makes sense for now

@kmyram kmyram added this to the Sprint 25 milestone Mar 9, 2020
@jauyong
Copy link
Author

jauyong commented Mar 10, 2020

Hey @samitron7 is there a design for where the looping option shows? Or is it the same as Jonny's screenshot above?
I looked at the media panel section and the design panel - video section in Figma.

@jauyong
Copy link
Author

jauyong commented Mar 10, 2020

@pbakaus the brief for Media-specific controls is also missing as denoted by the red text in the Product Spec doc.

@pbakaus
Copy link
Contributor

pbakaus commented Mar 20, 2020

@jauyong all related spec should be written. Note that there's a red "Panel:Video" in the spec, but we only really need that when we ship subsequent features not in v1.

@jauyong
Copy link
Author

jauyong commented Mar 20, 2020

I couldn't find where looping was covered in the docs but since this is in code review I'd assume Jonny found it

@pbakaus
Copy link
Contributor

pbakaus commented Mar 20, 2020

arrgh you're so right. The loop option was missing. Will add now.

@pbakaus
Copy link
Contributor

pbakaus commented Mar 20, 2020

@swissspidy
Copy link
Collaborator

Just realized that muting is deprecated in favor of using autoplay (which we already do), so we don't need to implement that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants