Respect first day of the week setting

[spacedmonkey]

Bug Description

WordPress has a setting for selecting the first day of the week. However, our date picker does not respect that.

See related WP core issue. #55826.

Expected Behaviour

Steps to Reproduce

Screenshots

Additional Context

• Plugin Version:
• WordPress Version:
• Operating System:
• Browser:

[swissspidy]

Oh good call. Looks like there's no explicit setting for first day of the week (wojtekmaj/react-calendar#10), but only a calendarType option:

const toCalendarType = (weekStartDay) =>
  weekStartDay === 0 ? 'US' : 'ISO 8601'
}

Maybe that works?

[spacedmonkey]

WordPress/gutenberg#41078

[spacedmonkey]

There is a PR on the gutenberg side - WordPress/gutenberg#41648

[swissspidy]

Gutenberg uses a different library for the date picker, so what works for them probably does not work for us.

[spacedmonkey]

Gutenberg uses a different library for the date picker, so what works for them probably does not work for us.

I know that 😉 Just sharing as this might help with our solution. There maybe also be parts of code, we need to consider for our solution.

[felipebochehin87]

@swissspidy morning!

While testing this PR (#11732) I noticed that Saturday, Sunday and Monday can be set as 1st days, but Friday can't. Is this something that we need to fix in this PR or can we create a new one for this scenario?

[swissspidy]

Nothing we can fix. The calendar we use does not support it.

[felipebochehin87]

Thanks! So the PR is approved.