Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev with dirty submodules #685

Closed
bhack opened this issue Jun 15, 2018 · 3 comments
Closed

Dev with dirty submodules #685

bhack opened this issue Jun 15, 2018 · 3 comments
Labels
area/tag kind/bug Something isn't working

Comments

@bhack
Copy link

bhack commented Jun 15, 2018 •
edited
Loading

Expected behavior

skaffold dev could work with dirty submodules

Actual behavior

skaffold dev fail with dirty submodules cause:
mq FATA[0267] first build: exiting dev mode because the first build failed: generating tag: reading diff: read <mysubmodulepath>: is a directory

Information

  • Skaffold version: 0.7
@r2d4 r2d4 added kind/bug Something isn't working area/tag labels Jun 15, 2018
@mattkelly mattkelly mentioned this issue Jun 20, 2018
Merged
@Lawouach
Copy link

I am also seeing that issue. However I didn't have it with 0.7 but it appeared with 0.8.

@bhack
Copy link
Author

bhack commented Jun 25, 2018

@Lawouach Can you test if is it solved with #711?

@Lawouach
Copy link

@bhack I can confirm that with that fix, I don't get the issue I had with 0.8.0 that was released last week.

@bhack bhack closed this as completed Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/tag kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Lawouach @r2d4 @bhack