Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl apply prune support #654

Closed
mxey opened this issue Jun 8, 2018 · 4 comments
Closed

kubectl apply prune support #654

mxey opened this issue Jun 8, 2018 · 4 comments

Comments

@mxey
Copy link

mxey commented Jun 8, 2018

David Gageot on Slack asked me to file this is as a feature request.

I'd like Skaffold to support the prune feature of kubectl, in both the kubectl and kustomize deployer.

@dlorenc
Copy link
Contributor

dlorenc commented Jun 13, 2018

Do you think this should be on always, or available as a flag?

@r2d4
Copy link
Contributor

r2d4 commented Jun 13, 2018

Always on won't let multiple users use skaffold on the same cluster (unless we prune on a user-specific label)

@mxey
Copy link
Author

mxey commented Jun 14, 2018

@dlorenc I think it should be a flag, because not everybody might want it, and having it on by default could be a bad surprise.

@r2d4 it definitely would have to be a user-specified label selector, so people could use it with multiple Skaffold-ed applications. It should be a label selector, not just a single label. For example, I might have a combination of app=myapp,environment=featurebranchXYZ.

Maybe just allow for arbitrary options to kubectl? Would also be useful for --force.

@nkubala
Copy link
Contributor

nkubala commented Nov 29, 2018

This should be fixed through #807

@nkubala nkubala closed this as completed Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants