Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skaffold run --port-forward behaves like it's freezing #3415

Closed
dgageot opened this issue Dec 20, 2019 · 2 comments · Fixed by #4113
Closed

skaffold run --port-forward behaves like it's freezing #3415

dgageot opened this issue Dec 20, 2019 · 2 comments · Fixed by #4113
Labels
area/portforward area/run fixit kind/bug Something isn't working kind/todo implementation task/epic for the skaffold team priority/p3 agreed that this would be good to have, but no one is available at the moment.

Comments

@dgageot
Copy link
Contributor

dgageot commented Dec 20, 2019

Starting with #3263, it's possible to run skaffold run --port-forward.

I found the behaviour puzzling, it looked like if it was freezing when in fact it was waiting for me to ctrl-c.
A message making that clear to the user might be good.

Another issue I have with this new behaviour is that I used to have export SKAFFOLD_PORT_FORWARD=true in my .bashrc. This was useful to have port forwarding always on for skaffold dev. Now I have to remove this line because it also enables pf for skaffold run which is something I very rarely want.

Finally, the PR introduces a regression here. The initial logs can be lost if the deployment takes more than a second.
@tejal29 tejal29 added area/portforward area/run priority/p2 May take a couple of releases kind/bug Something isn't working kind/todo implementation task/epic for the skaffold team labels Dec 20, 2019
@nkubala nkubala mentioned this issue Jan 8, 2020
Merged
7 tasks
@tstromberg
Copy link
Contributor

@dgageot - are you still seeing this behavior?

@dgageot
Copy link
Contributor Author

dgageot commented Apr 21, 2020

yes

@nkubala nkubala added fixit priority/p3 agreed that this would be good to have, but no one is available at the moment. and removed priority/p2 May take a couple of releases labels Apr 24, 2020
@gsquared94 gsquared94 mentioned this issue May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/portforward area/run fixit kind/bug Something isn't working kind/todo implementation task/epic for the skaffold team priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show message "Press ctrl c to exit" on forward manager start gsquared94/skaffold
4 participants
@tstromberg @dgageot @tejal29 @nkubala