skaffold.yaml produced by skaffold init --XXenableJibInit could be simpler

[dgageot]

When I run skaffold init --XXenableJibInit --force in examples/jib, I get this skaffold.yaml.

...
build:
  artifacts:
  - image: gcr.io/k8s-skaffold/skaffold-jib
    jib:
      args:
      - -Dimage=gcr.io/k8s-skaffold/skaffold-jib
      type: maven

I expected to get this kind of output:

build:
  artifacts:
  - image: gcr.io/k8s-skaffold/skaffold-jib
    jib: {}

any reason why we duplicate the image name?

[dgageot]

cc @saturnism

[loosebazooka]

I think @TadCordle had a reason for this (for adding the -Dimage)

[briandealwis]

#2854 for #2852

[TadCordle]

Yeah, this is intentional. If someone chooses to use Jib to build one of the k8s images, but the Jib config points to a different image, we need to specify the correct image using args in the skaffold.yaml. And I decided to just always specify args to make the code simpler.

[dgageot]

Shouldn't the value passed as an argument override the value in the pom.xml?

[TadCordle]

Yes, that is what it does. E.g. if pom.xml points to image-a but the user chooses that Jib project to build image-b during skaffold init, we pass -Dimage=image-b in the skaffold.yaml so the original image-a config is overridden.

[chanseokoh]

@TadCordle related, I am confused after I realized the Skaffold-Jib builder always appends -Dimage= at the end, so if I understood this right, this will end up passing -Dimage= twice where the last one provided by the builder will win and override the arg one. If that is true, then #2854 should have no effect, but that doesn't seem to be the case, so now I'm confused.

[TadCordle]

Ah, I see what you're saying now. I didn't realize Jib automatically appended the image flag during the build. If the same flag is used twice, it looks like gradle errors out, and maven just uses the last argument, so in that case we can probably just remove the arg generation during skaffold init.