Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow support for helm to recreate pods #289

Closed
PacoVK opened this issue Mar 27, 2018 · 0 comments · Fixed by #946
Closed

Allow support for helm to recreate pods #289

PacoVK opened this issue Mar 27, 2018 · 0 comments · Fixed by #946
Labels
area/deploy deploy/helm kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.

Comments

@PacoVK
Copy link

PacoVK commented Mar 27, 2018

Developing eg NodeJs using helm mechanism, skaffold detects changes and rebuild but helm doesn't recreate pods. With additional flag to recreate pods this would be possible.
Same for other flags eg dep-up.

Suggestion:

deploy:
helm:
releases:
- name: hello-world
chartPath: charts/hello-world
namespace: skaffold
args:
- recreate-pods
- dep-up
@stevenjm stevenjm mentioned this issue Aug 31, 2018
Merged
@balopat balopat added the priority/p3 agreed that this would be good to have, but no one is available at the moment. label Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/deploy deploy/helm kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass --recreate-pods to helm by default in dev mode
3 participants
@dgageot @balopat @PacoVK