Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC HTTP event endpoint is changed in the latest version of Skaffold #2435

Closed
quoctruong opened this issue Jul 9, 2019 · 0 comments · Fixed by #2436
Closed

RPC HTTP event endpoint is changed in the latest version of Skaffold #2435

quoctruong opened this issue Jul 9, 2019 · 0 comments · Fixed by #2436
Assignees
@nkubala
Labels
kind/bug Something isn't working priority/p0 Highest priority. We are actively looking at delivering it.

Comments

@quoctruong
Copy link

Expected behavior

Previously, if --rpc-http-port option is used, localhost:<port>/v1/event_log can be used to stream Skaffold events. However, this no longer works from Skaffold version 0.31 onwards.

Actual behavior

The endpoint is now changed to localhost:<port>/v1/events instead

Information

  • Skaffold version: version...0.31 and above
  • Operating system: ...Windows

Steps to reproduce the behavior

  1. Run skaffold command with --rpc-http-port argument.
  2. Navigate to http://localhost:<port>/v1/event_log
@balopat balopat added kind/bug Something isn't working priority/p0 Highest priority. We are actively looking at delivering it. labels Jul 9, 2019
@nkubala nkubala mentioned this issue Jul 9, 2019
Merged
@etanshaul etanshaul mentioned this issue Jul 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkubala nkubala

Labels
kind/bug Something isn't working priority/p0 Highest priority. We are actively looking at delivering it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add back /v1/event_log endpoint for events nkubala/skaffold
3 participants
@balopat @quoctruong @nkubala