-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] Add useHelmSecrets option to helm config #1178
Comments
This was referenced Oct 18, 2018
RoryShively
changed the title
Support Helm Plugins (specifically helm-secrets)
[Proposal] Support Helm Plugins (specifically helm-secrets)
Oct 22, 2018
RoryShively
changed the title
[Proposal] Support Helm Plugins (specifically helm-secrets)
[Proposal] Add useHelmSecrets option to helm config
Oct 29, 2018
I'm a +1 on this. @RoryShively would you like to send a PR? |
@nkubala Yeah. Sorry about the late reply, I'll get you something by the end of the day hopefully |
this should be fixed through #1617, thanks @RoryShively! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm rewriting this because it hasn't received enough attention. I originally had proposed to add plugins to the helm config but my proposed implementation was quite complicated. This new proposal has been greatly simplified
I created a PR for helm-secrets that will make integration with skaffold easier.
zendesk/helm-secrets#67
We can create a config option that will use helm-secrets if set to true to decrypt secrets on the fly before deployment. The config might look like this:
All that needs to change in the skaffold code is
pkg/skaffold/deploy/helm
line 110Add secrets as an argument if useHelmSecrets is true
The text was updated successfully, but these errors were encountered: