Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Add useHelmSecrets option to helm config #1178

Closed
RoryShively opened this issue Oct 18, 2018 · 4 comments
Closed

[Proposal] Add useHelmSecrets option to helm config #1178

RoryShively opened this issue Oct 18, 2018 · 4 comments

Comments

@RoryShively
Copy link
Contributor

RoryShively commented Oct 18, 2018

I'm rewriting this because it hasn't received enough attention. I originally had proposed to add plugins to the helm config but my proposed implementation was quite complicated. This new proposal has been greatly simplified

I created a PR for helm-secrets that will make integration with skaffold easier.
zendesk/helm-secrets#67

We can create a config option that will use helm-secrets if set to true to decrypt secrets on the fly before deployment. The config might look like this:

apiVersion: skaffold/v1alpha4
kind: Config
build:
  ...
deploy:
  helm:
    releases:
    - name: helm-secrets-test
      chartPath: helm_secrets_test
      valuesFiles:
      - helm_secrets_test/helm_vars/values.yaml
      - helm_secrets_test/helm_vars/secrets.yaml
      useHelmSecrets: true

All that needs to change in the skaffold code is pkg/skaffold/deploy/helm line 110

	args := append([]string{"secrets", "--kube-context", h.kubeContext}, arg...)

Add secrets as an argument if useHelmSecrets is true

@RoryShively RoryShively changed the title Support Helm Plugins (specifically helm-secrets) [Proposal] Support Helm Plugins (specifically helm-secrets) Oct 22, 2018
@RoryShively RoryShively changed the title [Proposal] Support Helm Plugins (specifically helm-secrets) [Proposal] Add useHelmSecrets option to helm config Oct 29, 2018
@nkubala
Copy link
Contributor

nkubala commented Nov 30, 2018

I'm a +1 on this. @RoryShively would you like to send a PR?

@RoryShively
Copy link
Contributor Author

@nkubala Yeah. Sorry about the late reply, I'll get you something by the end of the day hopefully

@RoryShively
Copy link
Contributor Author

@nkubala Just submitted a first draft
#1617

  • Placed useHelmSecrets option in latest schema
  • prepended "secrets" to args for helm deployment if useHelmSecrets selected

@nkubala
Copy link
Contributor

nkubala commented Sep 9, 2019

this should be fixed through #1617, thanks @RoryShively!

@nkubala nkubala closed this as completed Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants