From ad299984569bcd6e8d0052d4d3eb00bee5c17075 Mon Sep 17 00:00:00 2001 From: balopat Date: Thu, 15 Nov 2018 12:00:42 -0800 Subject: [PATCH 1/4] upgrading golangci-lint to 1.12.2 --- hack/linter.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hack/linter.sh b/hack/linter.sh index c3a55355b7b..976970ee4e9 100755 --- a/hack/linter.sh +++ b/hack/linter.sh @@ -20,11 +20,12 @@ DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" if ! [ -x "$(command -v golangci-lint)" ]; then echo "Installing GolangCI-Lint" - ${DIR}/install_golint.sh -b $GOPATH/bin v1.9.3 + ${DIR}/install_golint.sh -b $GOPATH/bin v1.12.2 fi golangci-lint run \ --no-config \ + --disable-all \ -E goconst \ -E goimports \ -E golint \ @@ -33,4 +34,4 @@ golangci-lint run \ -E misspell \ -E unconvert \ -E unparam \ - -D errcheck + --skip-dirs vendor \ No newline at end of file From 669601a309aefebd97580ad3207fbdf8cdcd798c Mon Sep 17 00:00:00 2001 From: balopat Date: Thu, 15 Nov 2018 12:01:43 -0800 Subject: [PATCH 2/4] adding go 1.11 to travis matrix --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index e3231b78220..4a4ea161ea6 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,6 +4,7 @@ os: - osx go: - "1.10.x" + - "1.11.x" go_import_path: github.com/GoogleContainerTools/skaffold before_script: From 37cb9ac170bb82525164cd2ad1064b4953f18e05 Mon Sep 17 00:00:00 2001 From: balopat Date: Thu, 15 Nov 2018 12:07:44 -0800 Subject: [PATCH 3/4] reenabling everything we previously had except typecheck --- hack/linter.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hack/linter.sh b/hack/linter.sh index 976970ee4e9..e325e839ede 100755 --- a/hack/linter.sh +++ b/hack/linter.sh @@ -25,7 +25,6 @@ fi golangci-lint run \ --no-config \ - --disable-all \ -E goconst \ -E goimports \ -E golint \ @@ -34,4 +33,6 @@ golangci-lint run \ -E misspell \ -E unconvert \ -E unparam \ + -D typecheck \ + -D errcheck \ --skip-dirs vendor \ No newline at end of file From 96a73d6a1d25a172f7ee2c18e0584534c5fcfb29 Mon Sep 17 00:00:00 2001 From: balopat Date: Thu, 15 Nov 2018 12:09:20 -0800 Subject: [PATCH 4/4] testing typecheck against 1.11 --- hack/linter.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/hack/linter.sh b/hack/linter.sh index e325e839ede..ad9dbc05e95 100755 --- a/hack/linter.sh +++ b/hack/linter.sh @@ -33,6 +33,5 @@ golangci-lint run \ -E misspell \ -E unconvert \ -E unparam \ - -D typecheck \ -D errcheck \ --skip-dirs vendor \ No newline at end of file