Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make push in Makefile #819

Closed
prary opened this issue Oct 15, 2019 · 4 comments · Fixed by #866
Closed

make push in Makefile #819

prary opened this issue Oct 15, 2019 · 4 comments · Fixed by #866
Labels
area/internal bugs related to kaniko development workflow kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.

Comments

@prary
Copy link
Contributor

prary commented Oct 15, 2019

Feature requirement
How about the idea of push phony in Makefile

Description Yes/No
Please check if this a new feature you are proposing
  • - [ Yes ]
Please check if the build works in docker but not in kaniko
  • - [ No ]
Please check if this error is seen when you use --cache flag
  • - [ No ]
Please check if your dockerfile is a multistage dockerfile
  • - [ No ]
@priyawadhwa
Copy link
Collaborator

Hey @prary what image would this be pushing?

@prary
Copy link
Contributor Author

prary commented Oct 15, 2019 •
edited
Loading

@priyawadhwa kaniko image build in make images step

@tejal29
Copy link
Member

tejal29 commented Oct 16, 2019

sure. you add a push target to makefile and use it 👍

@tejal29 tejal29 added kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment. labels Oct 16, 2019
@prary
Copy link
Contributor Author

prary commented Oct 16, 2019

Great i'll raise a PR for it

@tejal29 tejal29 added meta/internal area/behavior all bugs related to kaniko behavior like running in as root area/internal bugs related to kaniko development workflow and removed area/behavior all bugs related to kaniko behavior like running in as root meta/internal labels Oct 16, 2019
@prary prary mentioned this issue Nov 16, 2019
Merged
@cvgw cvgw closed this as completed in #866 Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/internal bugs related to kaniko development workflow kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Push image prary/kaniko
3 participants
@tejal29 @prary @priyawadhwa