Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails when FROM image AS alias has capital letters #770

Closed
BenHizak opened this issue Sep 16, 2019 · 4 comments · Fixed by #839
Closed

Build fails when FROM image AS alias has capital letters #770

BenHizak opened this issue Sep 16, 2019 · 4 comments · Fixed by #839
Labels
area/multi-stage builds issues related to kaniko multi-stage builds easy-fix help wanted Looking for a volunteer! kind/bug Something isn't working priority/p1 Basic need feature compatibility with docker build. we should be working on this next.

Comments

@BenHizak
Copy link

BenHizak commented Sep 16, 2019

Actual behavior
Named build stages (FROM someimage as myname) fail when name begins with a Capital letter
Example:

  1. FROM python:3.7.2 AS library ✔ builds successfully (note that there are no capital letters)
  2. FROM python:3.7.2 AS Library ❌ fails (note that there is a capital letter)
    Error shown
Downloading base image Library               
error building image: could not parse reference
ERROR

Expected behavior
When using named stages, capital letters should not break the build process
To Reproduce
Please see this gist

@BenHizak BenHizak changed the title Build fails when image alias has capitals Build fails when FROM image AS alias has capital letters Sep 16, 2019
@tejal29 tejal29 added kind/bug Something isn't working help wanted Looking for a volunteer! priority/p1 Basic need feature compatibility with docker build. we should be working on this next. area/multi-stage builds issues related to kaniko multi-stage builds labels Sep 20, 2019
@N4rm0
Copy link
Contributor

N4rm0 commented Sep 22, 2019

@tejal29 PR #787 should fix this issue.
Edit: Just realized the issue lies in 3rd party code (moby/buildkit), so I am dropping my PR as the fix should be made in the vendor code.

@tejal29
Copy link
Member

tejal29 commented Oct 2, 2019

Awesome! we should update to latest moby/buildkit

@antechrestos
Copy link
Contributor

antechrestos commented Oct 26, 2019

@N4rm0 you should report your fix in vendor code because currently the problem is still present

Upgrading to the latest moby/buildkit will not fix the issue

@antechrestos
Copy link
Contributor

@tejal29 I implemented a small fix by implementing it in the resolution in order not to change third party library behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/multi-stage builds issues related to kaniko multi-stage builds easy-fix help wanted Looking for a volunteer! kind/bug Something isn't working priority/p1 Basic need feature compatibility with docker build. we should be working on this next.
Projects
None yet
4 participants