fix: expose secure-cloud-run-core module timeout_seconds input to secure_cloud_run module
#225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffsays
requested review from
prabhu34,
anamer,
gtsorbo and
a team
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jeffsays
force-pushed
the
expose-secure-cloud-run-timeout-seconds-var
branch
from
3003879
to
ab6c543
Compare
… `secure_cloud_run` module
jeffsays
force-pushed
the
expose-secure-cloud-run-timeout-seconds-var
branch
from
ab6c543
to
04844b2
Compare
jeffsays
changed the title
secure-cloud-run-core module timeout_seconds variable to secure_cloud_run modulesecure-cloud-run-core module timeout_seconds input to secure_cloud_run module
|
/gcbrun |
|
/gcbrun |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose
timeout_secondsvariable fromsecure-cloud-run-coremodule tosecure_cloud_runmodule when calling it.Closes #224