Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update Terraform versioning, improve dependency tree, remove unused table, add Managed Tables to Dataplex Assets #72

Merged
merged 20 commits into from
Oct 4, 2023
Merged

fix: Update Terraform versioning, improve dependency tree, remove unused table, add Managed Tables to Dataplex Assets #72

merged 20 commits into from
Oct 4, 2023

Conversation

bradmiro
Copy link
Collaborator

@bradmiro bradmiro commented Sep 21, 2023 •
edited
Loading

  • Update Terraform version and pinned requirements (needed for new Dataplex Asset updates to work)
  • Removed many unneeded explicit dependencies (in favor of implicit)
  • Removed "wait_after_all_resources" wait block and moved these dependencies where needed
  • Removed an unused BigQuery table that is created
  • Add the new "readAccessMode" config to the Dataplex assets
  • Changed BigQuery job to support both stage and non-stage prefix tables

@bradmiro bradmiro requested review from davenportjw and a team as code owners September 21, 2023 22:39
@bradmiro
Copy link
Collaborator Author

bradmiro commented Sep 21, 2023 •
edited
Loading

/gcbrun

@bradmiro bradmiro changed the title (fix) Improve dependency tree, remove unused table, add Managed Tables to Dataplex Assets fix: Improve dependency tree, remove unused table, add Managed Tables to Dataplex Assets Sep 21, 2023
@bradmiro bradmiro changed the title fix: Improve dependency tree, remove unused table, add Managed Tables to Dataplex Assets fix: Update Terraform versioning, improve dependency tree, remove unused table, add Managed Tables to Dataplex Assets Sep 26, 2023
@bradmiro bradmiro force-pushed the dev branch 2 times, most recently from 3be8654 to 0820ee8 Compare September 27, 2023 21:21
bradmiro added 20 commits October 4, 2023 12:21
@bradmiro
changing dataplex tables to managed by default, removing manual 'upgr…
c05bc7a 
…ade' logic
@bradmiro
scrubbing unnecessary explicit 'depends_on'
308f2dc
@bradmiro
remove creating bq external table
752e109
@bradmiro
adding options for stage and nonstage table prefix
c4e2b7a
@bradmiro
remove wait_after_all_resources and move dependencies to more appropr…
642073f 
…iate spots
@bradmiro
fixes
e83e8d9
@bradmiro
updating terraform version
869d5ae
@bradmiro
removing temporary bucket
c14106d
@bradmiro
lint fixes
0865d58
@bradmiro
lint cleanup
23b335c
@bradmiro
remove 'delete_protection' from example
af117fd
@bradmiro
resolving merge conflict
9c9b1ec
@bradmiro
removing delete_protection, fixing docstrings, adding public_data_buc…
28ec8c7 
…ket to workflow
@bradmiro
revert version pinning
b60add1
@bradmiro
updating examples
b2131cc
@bradmiro
moving vars around
a89b7b6
@bradmiro
lint fix
1909f2c
@bradmiro
adding docs updates
cbc5ee1
@bradmiro
remove stage_ references
f8771b7
@bradmiro
added comment to dataplex bucket
b893a58
@bradmiro bradmiro merged commit 9283feb into GoogleCloudPlatform:main Oct 4, 2023
@release-please release-please bot mentioned this pull request Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davenportjw davenportjw davenportjw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bradmiro @davenportjw