-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: document configuring multiple release branches #245
Conversation
@OrenMe don't suppose you'd be willing to try these docs out, and see if it work for your patch based workflow? |
@bcoe This looks good, but it also requires to have some prior knowledge of the branch prefix. I also tested this and it acts funny with the main branch PR that release-please opens. |
@OrenMe what behavior happened? |
@bcoe it reused the same PR that was already opened for the main branch and iirc it was kind of messed up in commit order as it didn't take it cleanly from the new patch branch. I think it can be better if new target branch PRs be separate and not reuse a single PR across targets. |
@OrenMe I think this is an issue @chingor13 brought up with me already, which happens if the alternate branch and the current branch share the same version range. The plan to solve the problem is to move to a new branch naming format, which includes the name of the target branch. |
Thanks @bcoe, sounds like that will do the trick. |
@OrenMe created tracking issue here: |
Towards #244