From 7de4373542441a6383ebee63fe8389f7251bbd25 Mon Sep 17 00:00:00 2001
From: Lin Guo <linsword13@gmail.com>
Date: Thu, 23 May 2024 19:59:38 -0700
Subject: [PATCH] Remove deprecated spack schemas

---
 .../docs/dev_guides/application_dev_guide.rst |  1 +
 lib/ramble/ramble/schema/spack.py             | 19 -------------------
 lib/ramble/ramble/test/cmd/workspace.py       |  1 -
 .../ramble/test/end_to_end/env_var_builtin.py |  1 -
 4 files changed, 1 insertion(+), 21 deletions(-)

diff --git a/lib/ramble/docs/dev_guides/application_dev_guide.rst b/lib/ramble/docs/dev_guides/application_dev_guide.rst
index abb0e4fce..f234a0d20 100644
--- a/lib/ramble/docs/dev_guides/application_dev_guide.rst
+++ b/lib/ramble/docs/dev_guides/application_dev_guide.rst
@@ -265,6 +265,7 @@ directives that are intended to be package manager specific. As an example,
 there are directives for Spack defined by:
 
 * :meth:`ramble.language.shared_language.software_spec`
+* :meth:`ramble.language.shared_language.define_compiler`
 * :meth:`ramble.language.shared_language.required_package`
 
 These provide Ramble with information about how Spack could install and require
diff --git a/lib/ramble/ramble/schema/spack.py b/lib/ramble/ramble/schema/spack.py
index 6d2adc187..4ea5d9582 100644
--- a/lib/ramble/ramble/schema/spack.py
+++ b/lib/ramble/ramble/schema/spack.py
@@ -12,21 +12,12 @@
    :lines: 12-
 """  # noqa E501
 
-import ramble.schema.variables
-import ramble.schema.applications
-import ramble.schema.zips
 
 #: Properties for inclusion in other schemas
 properties = {
     'spack': {
         'type': 'object',
         'properties': {
-            'concretized': {
-                'type': 'boolean',
-                'default': None
-            },
-            'variables': ramble.schema.variables.variables_def,
-            'zips': ramble.schema.zips.zips_def,
             'packages': {
                 'type': 'object',
                 'additionalProperties': {
@@ -41,11 +32,6 @@
                             'type': 'string',
                             'default': None,
                         },
-                        'variables': ramble.schema.variables.variables_def,
-                        'zips': ramble.schema.zips.zips_def,
-                        'matrix': ramble.schema.applications.matrix_def,
-                        'matrices': ramble.schema.applications.matrices_def,
-                        'exclude': ramble.schema.applications.exclude_def,
                     },
                     'additionalProperties': False,
                     'default': {}
@@ -67,11 +53,6 @@
                             'items': {'type': 'string'},
                             'default': []
                         },
-                        'variables': ramble.schema.variables.variables_def,
-                        'zips': ramble.schema.zips.zips_def,
-                        'matrix': ramble.schema.applications.matrix_def,
-                        'matrices': ramble.schema.applications.matrices_def,
-                        'exclude': ramble.schema.applications.exclude_def,
                     },
                     'additionalProperties': False,
                     'default': {}
diff --git a/lib/ramble/ramble/test/cmd/workspace.py b/lib/ramble/ramble/test/cmd/workspace.py
index 65e00fe70..dc896ff0a 100644
--- a/lib/ramble/ramble/test/cmd/workspace.py
+++ b/lib/ramble/ramble/test/cmd/workspace.py
@@ -1896,7 +1896,6 @@ def test_workspace_simplify():
               variables:
                 n_nodes: '1'
   spack:
-    concretized: true
     packages:
       zlib:
         spack_spec: zlib
diff --git a/lib/ramble/ramble/test/end_to_end/env_var_builtin.py b/lib/ramble/ramble/test/end_to_end/env_var_builtin.py
index b61e137be..7005399e8 100644
--- a/lib/ramble/ramble/test/end_to_end/env_var_builtin.py
+++ b/lib/ramble/ramble/test/end_to_end/env_var_builtin.py
@@ -144,7 +144,6 @@ def test_env_var_from_app_only(mutable_config, mutable_mock_workspace_path, mock
               variables:
                 n_nodes: 1
   spack:
-    concretized: true
     packages: {}
     environments: {}
 """