Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubsub: incorrect region tag in async sample #2330

Closed
hongalex opened this issue Aug 11, 2019 · 3 comments · Fixed by #2334 or GoogleCloudPlatform/ruby-docs-samples#443
Closed

pubsub: incorrect region tag in async sample #2330

hongalex opened this issue Aug 11, 2019 · 3 comments · Fixed by #2334 or GoogleCloudPlatform/ruby-docs-samples#443

Comments

@hongalex
Copy link
Contributor

def receive_messages_with_custom_attributes(project_id, subscription_name):
"""Receives messages from a pull subscription."""
# [START pubsub_subscriber_sync_pull_custom_attributes]

This sample uses a region tag that says pubsub_subscriber_sync_pull_custom_attributes, but in reality, the messages are being received asynchronously using subscriber.subscribe. We need to update the region tag and referencing docs.

There's a similar issues with the Ruby samples

@anguillanneuf
Copy link
Member

anguillanneuf commented Aug 12, 2019

@hongalex Shall we standardize the region tag here as pubsub_subscriber_async_pull_custom_attributes for all languages?

@hongalex
Copy link
Contributor Author

Sounds good to me. Can you update the tracker? Thanks!

@anguillanneuf
Copy link
Member

Sure! Just need to make sure we don't delete these tags until changes are published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants