Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating setters formatting and comments #815

Merged
merged 5 commits into from
Feb 5, 2024

Conversation

johnswayty-ssc
Copy link
Collaborator

closes #783 fixed setters.yaml formatting and added comments.

@johnswayty-ssc johnswayty-ssc marked this pull request as ready for review February 5, 2024 19:39
Copy link
Collaborator

@tackaberry tackaberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. These will be great changes when applied to the other solutions. I imagine this is next in the workflow.

Copy link
Collaborator

@lucstjean-ssc lucstjean-ssc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm. Good work!

Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cursory reviewed
/lgtm

@johnswayty-ssc johnswayty-ssc merged commit c105800 into main Feb 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: update experimentation pkg setters formatting and comments
4 participants