Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: namespace-defaults - adding sa for wi and update network policy #518

Merged
merged 1 commit into from
Sep 8, 2023
Merged

feat: namespace-defaults - adding sa for wi and update network policy #518

merged 1 commit into from
Sep 8, 2023

Conversation

davelanglois-ssc
Copy link
Collaborator

@davelanglois-ssc davelanglois-ssc commented Sep 7, 2023 •
edited
Loading

updating kubernetes namespace-defaults package

  • Creates Kuberenetes Service Account to be used by applications deployed in the namespace. Kubernetes Service Account is annotated with the Google Service Account to which it is bound using workload identity.
  • Network policy to allow access to NodeLocal DNSCache on ip 169.254.20.10 and port 53
  • Network policy to allow egress for GCP API
  • update README.md

contributes to #479

@davelanglois-ssc davelanglois-ssc changed the title fix: adding sa for wi and update network policy fix: namespace-defaults - adding sa for wi and update network policy Sep 7, 2023
@davelanglois-ssc davelanglois-ssc marked this pull request as ready for review September 7, 2023 11:35
@davelanglois-ssc davelanglois-ssc changed the title fix: namespace-defaults - adding sa for wi and update network policy feat: namespace-defaults - adding sa for wi and update network policy Sep 7, 2023
fmichaelobrien
fmichaelobrien approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • nice one

@cartyc cartyc merged commit ea3d8b0 into main Sep 8, 2023
@pubsec-declarative-toolkit-bot pubsec-declarative-toolkit-bot mentioned this pull request Sep 8, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkodjurkovic-ssc borkodjurkovic-ssc borkodjurkovic-ssc approved these changes

@alaincormier-ssc alaincormier-ssc alaincormier-ssc approved these changes

@fmichaelobrien fmichaelobrien fmichaelobrien approved these changes

@cartyc cartyc cartyc approved these changes

@lucstjean-ssc lucstjean-ssc Awaiting requested review from lucstjean-ssc

@Michael-McAuley-SSC Michael-McAuley-SSC Awaiting requested review from Michael-McAuley-SSC

@stephanemillaire-ssc stephanemillaire-ssc Awaiting requested review from stephanemillaire-ssc

@anoopsidhu-ssc anoopsidhu-ssc Awaiting requested review from anoopsidhu-ssc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davelanglois-ssc @cartyc @fmichaelobrien @alaincormier-ssc @borkodjurkovic-ssc