feat: Prevent exceptions due to PostgreSQL xml data type #1384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR duplicates Ibis 9.2 behaviour for PostgreSQL xml data type to DVT. In essence this maps xml columns to data type "unknown".
I tested with the commands below.
Schema validation no longer throws an exception but does show the type as "unknown":
Column validation includes the XML column for count but skips it for min/max/sum:
Row validation includes the column:
I've added a column to the
pso_data_validator.dvt_pg_types
test table in the repo but cannot yet add it to the actual test table because tests on other branches will then fail. I do that part after we decide on correct behaviour and approve the PR in principal.