Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support int64 histograms #633

Closed
damemi opened this issue May 26, 2023 · 1 comment
Closed

Support int64 histograms #633

damemi opened this issue May 26, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@damemi
Copy link
Contributor

damemi commented May 26, 2023

          As a note, I think it is fine that we are only handling float64 histograms here, because 
  1. this code is just handling testcases.
  2. Sum is the only value used here that can be int or float in metricdata.Histogram[N] (we don't read Min or Max) and Sum() always returns a float64, so there shouldn't be any runtime issues with this.
  3. We force float64 when we handle Sum anyway, which is consistent with the behavior prior to this update and therefore not breaking.

However, we should follow this up with support for int64 histograms. Otherwise, users who switch to the GCP exporter might see slightly different values since we force floats in the output calculation. That would include adding a test case for an int64 histogram, which we don't appear to have currently. Will make a separate issue to track this.

Originally posted by @damemi in #620 (comment)

@damemi damemi added the enhancement New feature or request label May 26, 2023
@damemi
Copy link
Contributor Author

damemi commented Jun 6, 2023

Going to close this, it's not a top priority and unlikely to be a huge issue.

@damemi damemi closed this as completed Jun 6, 2023
@damemi damemi reopened this Jun 6, 2023
@damemi damemi closed this as not planned Won't fix, can't repro, duplicate, stale Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant