Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presubmit for run/markdown-preview/editor is consistently failing #1791

Closed
fhinkel opened this issue May 7, 2020 · 4 comments
Closed

Presubmit for run/markdown-preview/editor is consistently failing #1791

fhinkel opened this issue May 7, 2020 · 4 comments
Assignees
@grayside @averikitsch
Labels
api: run Issues related to the Cloud Run API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@fhinkel
Copy link
Contributor

fhinkel commented May 7, 2020

https://source.cloud.google.com/results/invocations/32813175-423a-4ddf-9065-e7da9f31cea5/targets
https://source.cloud.google.com/results/invocations/e393577d-e306-4540-b4c9-141aea0747f4/targets
@fhinkel fhinkel added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. api: run Issues related to the Cloud Run API. labels May 7, 2020
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels May 12, 2020
@grayside
Copy link
Collaborator

Note that a CL was submitted enabling Kokoro testing for a sample still in development. This will be fixed in #1752.

@grayside grayside added priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. and removed 🚨 This issue needs some love. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 20, 2020
@grayside
Copy link
Collaborator

Not sure what priority this has, but adjusting the labels to indicate this bug only exists as a flag to indicate this test failure can be ignored.

@averikitsch
Copy link
Contributor

I assume we will be able to merge this sample at least by next week. Though an option would be to revert the CL.

@grayside
Copy link
Collaborator

Duplicate of #1877 and #1878

This was referenced Apr 7, 2022
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grayside grayside

@averikitsch averikitsch

Labels
api: run Issues related to the Cloud Run API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fhinkel @grayside @averikitsch @yoshi-automation