Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal CI (run/hello-broken) - Tests failed #1603

Closed
ricardolsmendes opened this issue Feb 12, 2020 · 1 comment
Closed

Internal CI (run/hello-broken) - Tests failed #1603

ricardolsmendes opened this issue Feb 12, 2020 · 1 comment
Labels
triage me I really want to be triaged.

Comments

@ricardolsmendes
Copy link
Contributor

I've noticed Internal CI (run/hello-broken) is breaking the CI pipeline and preventing unrelated changes to be merged. I'm not familiar with Cloud Run samples, but investigating the error logs generated for a PR I submitted earlier, it turns out Broken resource uses the NAME override might be the culprit.

it('Broken resource uses the NAME override', async () => {
const response = await get('/', BASE_URL_OVERRIDE);
assert.strictEqual(
response.statusCode,
200,
'Did not use the NAME override'
);
assert.strictEqual(
response.body,
`Hello ${NAME}!`,
`Expected override "${NAME}" not found`
);
});

Would you be able to take a look at this?

Thanks!

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Feb 13, 2020
@fhinkel
Copy link
Contributor

fhinkel commented Feb 13, 2020

We know that those tests fail, that's why they're optional for merging.

@grayside any thought on when they'll be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants