Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile linting to CI #1374

Closed
ace-n opened this issue Jun 19, 2019 · 4 comments
Closed

Add Dockerfile linting to CI #1374

ace-n opened this issue Jun 19, 2019 · 4 comments
Assignees

Comments

@ace-n
Copy link
Contributor

ace-n commented Jun 19, 2019

Per @grayside's comment here - we should consider adding hadolint (or a similar Docker linting system) to CI.

(Aside: it does take eng. time, but my vote is 100% in favor of adding as many CI checks as we can.)

@grayside
Copy link
Collaborator

The easiest way to run hadolint is via docker:

docker run --rm -i hadolint/hadolint < Dockerfile

However, docker is not currently available in the workspace container image.

@fhinkel
Copy link
Contributor

fhinkel commented Jun 22, 2019

Sounds good. Is hadolint what we use in other libraries?

@grayside
Copy link
Collaborator

I've not seen anything used for Dockerfile linting in Google repos

@fhinkel
Copy link
Contributor

fhinkel commented Jul 15, 2019

Closing this as there are more pressing issues in this repo. Feel free to re-open if you want to work on it.

@fhinkel fhinkel closed this as completed Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants