From 03b3d4d7ba3572781f820486310b5a59bac08968 Mon Sep 17 00:00:00 2001 From: Justin Beckwith Date: Thu, 4 Apr 2019 21:15:11 -0700 Subject: [PATCH] refactor: use execSync for tests (#127) --- asset/snippets/package.json | 3 +- asset/snippets/system-test/.eslintrc.yml | 3 - asset/snippets/system-test/quickstart.test.js | 57 ------------------- 3 files changed, 1 insertion(+), 62 deletions(-) delete mode 100644 asset/snippets/system-test/.eslintrc.yml delete mode 100644 asset/snippets/system-test/quickstart.test.js diff --git a/asset/snippets/package.json b/asset/snippets/package.json index 38c6c9eea3..527c478b30 100644 --- a/asset/snippets/package.json +++ b/asset/snippets/package.json @@ -12,7 +12,7 @@ "repository": "googleapis/nodejs-asset", "private": true, "scripts": { - "test": "mocha system-test --timeout 20000" + "test": "mocha --timeout 20000" }, "dependencies": { "@google-cloud/asset": "^0.3.0", @@ -22,7 +22,6 @@ }, "devDependencies": { "chai": "^4.2.0", - "execa": "^1.0.0", "mocha": "^6.0.0" } } diff --git a/asset/snippets/system-test/.eslintrc.yml b/asset/snippets/system-test/.eslintrc.yml deleted file mode 100644 index 6db2a46c53..0000000000 --- a/asset/snippets/system-test/.eslintrc.yml +++ /dev/null @@ -1,3 +0,0 @@ ---- -env: - mocha: true diff --git a/asset/snippets/system-test/quickstart.test.js b/asset/snippets/system-test/quickstart.test.js deleted file mode 100644 index e04aa190ea..0000000000 --- a/asset/snippets/system-test/quickstart.test.js +++ /dev/null @@ -1,57 +0,0 @@ -/** - * Copyright 2018, Google, LLC. - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -'use strict'; - -const {assert} = require('chai'); -const path = require('path'); -const uuid = require('uuid'); -const execa = require('execa'); -const {Storage} = require('@google-cloud/storage'); - -const cwd = path.join(__dirname, '..'); -const cmd = 'node quickstart.js'; - -const storage = new Storage(); -const bucketName = `asset-nodejs-${uuid.v4()}`; -const bucket = storage.bucket(bucketName); - -describe('quickstart sample tests', () => { - before(async () => { - await bucket.create(); - }); - - after(async () => { - await bucket.delete(); - }); - - it('should export assets to specified path', async () => { - const dumpFilePath = `gs://${bucketName}/my-assets.txt`; - await execa.shell(`${cmd} export-assets ${dumpFilePath}`, {cwd}); - const file = await bucket.file('my-assets.txt'); - const exists = await file.exists(); - assert.ok(exists); - await file.delete(); - }); - - it('should get assets history successfully', async () => { - const assetName = `//storage.googleapis.com/${bucketName}`; - const {stdout} = await execa.shell( - `${cmd} batch-get-history ${assetName}`, - {cwd} - ); - assert.match(stdout, new RegExp(assetName)); - }); -});