Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various breaking changes in docs/kustomize #1202

Merged
merged 4 commits into from
Oct 24, 2022
Merged

Fix various breaking changes in docs/kustomize #1202

merged 4 commits into from
Oct 24, 2022

Conversation

mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented Oct 23, 2022 •
edited
Loading

@mathieu-benoit mathieu-benoit requested a review from a team as a code owner October 23, 2022 15:49
@mathieu-benoit mathieu-benoit marked this pull request as draft October 23, 2022 15:50
@mathieu-benoit mathieu-benoit mentioned this pull request Oct 23, 2022
Merged
@mathieu-benoit mathieu-benoit changed the title Fix various breaking change in docs/kustomize Fix various breaking changes in docs/kustomize Oct 23, 2022
@github-actions
Copy link

🚲 PR staged at http://34.170.3.147

@github-actions
Copy link

🚲 PR staged at http://34.170.3.147

@github-actions
Copy link

🚲 PR staged at http://34.170.3.147

@mathieu-benoit mathieu-benoit mentioned this pull request Oct 23, 2022
Merged
4 tasks
@mathieu-benoit mathieu-benoit marked this pull request as ready for review October 23, 2022 16:53
@mathieu-benoit
Copy link
Contributor Author

Ready for your review, thanks!

@NimJay NimJay merged commit e28bd82 into main Oct 24, 2022
@NimJay NimJay deleted the mathieu-benoit/various-fix branch October 24, 2022 10:21
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
@mathieu-benoit
Fix various breaking changes in docs/kustomize (GoogleCloudPlatform#1202
925c98e 
)

* Fix REDIS_ADDR token replacement

* Fix broken workload-identity link

* add redis in container-image-registry kustomize overlay

* Fix issue with loadgenerator and frontend for the native-grpc-health-check Kustomize component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NimJay NimJay NimJay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathieu-benoit @NimJay