Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken Link in Workload Identity #1195

Closed
LukeSchlangen opened this issue Oct 21, 2022 · 1 comment · Fixed by #1201
Closed

Broken Link in Workload Identity #1195

LukeSchlangen opened this issue Oct 21, 2022 · 1 comment · Fixed by #1201
Labels
good first issue This issue is a good place to started contributing to this repository.

Comments

@LukeSchlangen
Copy link
Member

Describe the bug

Workload Identity link leads to 404

To Reproduce

  1. https://github.com/GoogleCloudPlatform/microservices-demo/blob/main/docs/development-guide.md#option-1-google-kubernetes-engine-gke
  1. Click link that says see these instructions
  1. You will be redirected to a 404 page. It seems this file has been removed from the docs folder

Exposure

Persistent
@mathieu-benoit
Copy link
Contributor

mathieu-benoit commented Oct 21, 2022 •
edited
Loading

Good catch @LukeSchlangen, thanks for reporting the issue. We indeed recently simplified that part in this repo by just targeting the official WI setup page now. We missed that one (and maybe other places?).

Note: To anyone who would like to fix that, the link should land there now: https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity#enable.

@mathieu-benoit mathieu-benoit added the good first issue This issue is a good place to started contributing to this repository. label Oct 21, 2022
@feitnomore feitnomore mentioned this issue Oct 23, 2022
Merged
@mathieu-benoit mathieu-benoit linked a pull request Oct 23, 2022 that will close this issue
Fix Enabling Workload Identity Link #1201
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue This issue is a good place to started contributing to this repository.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Enabling Workload Identity Link feitnomore/microservices-demo
2 participants
@LukeSchlangen @mathieu-benoit