Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change description of Gemini Gcp Enablement Setting Resource #13017

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PerlMonker303
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

Changed description of Gemini Gcp Enablement Setting resource

@github-actions github-actions bot requested a review from shuyama1 February 10, 2025 10:31
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 5 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 2 files changed, 10 insertions(+), 10 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_gemini_gcp_enablement_setting (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_gemini_gcp_enablement_setting" "primary" {
  labels = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 14
Passed tests: 14
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • gemini

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants