Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Upgrade to the latest google-cloud-logging library #221

Closed
meltsufin opened this issue Jan 5, 2018 · 2 comments · Fixed by #222
Closed

Upgrade to the latest google-cloud-logging library #221

meltsufin opened this issue Jan 5, 2018 · 2 comments · Fixed by #222
Assignees

Comments

@meltsufin
Copy link
Member

We also should start using the Google Cloud Java BOM for managing library versions from Google Cloud Java.

Potential solution to #217.

@ChengyuanZhao ChengyuanZhao self-assigned this Jan 5, 2018
@ChengyuanZhao
Copy link
Member

ChengyuanZhao commented Jan 5, 2018

@meltsufin The BOM for google cloud java includes many things we don't currently explicitly import in the jetty9-base pom.xml (which is then used throughout the rest of this repo): https://github.com/GoogleCloudPlatform/google-cloud-java/tree/master/google-cloud-bom

I assume we definitely don't want to manage a list of things to exclude from the BOM, right ? I think that adds an amount of annoyance that outweighs the benefits.

@meltsufin
Copy link
Member Author

The BOM only has versions for dependencies. It shouldn't actually bring in any of the dependencies.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants