From 4df07bd7ffb49d1a4209dd3574ef48b77b71c8e9 Mon Sep 17 00:00:00 2001 From: Jerjou Cheng Date: Mon, 24 Oct 2016 13:27:41 -0700 Subject: [PATCH 1/2] Update test language to be more negative. --- language/analysis/pom.xml | 2 +- .../java/com/google/cloud/language/samples/AnalyzeIT.java | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/language/analysis/pom.xml b/language/analysis/pom.xml index 205f06392ca..2b9ab116120 100644 --- a/language/analysis/pom.xml +++ b/language/analysis/pom.xml @@ -18,7 +18,7 @@ limitations under the License. jar 1.0-SNAPSHOT com.google.cloud.language.samples - entities + language-entities diff --git a/language/analysis/src/test/java/com/google/cloud/language/samples/AnalyzeIT.java b/language/analysis/src/test/java/com/google/cloud/language/samples/AnalyzeIT.java index 63b2663c790..737c4b197d0 100644 --- a/language/analysis/src/test/java/com/google/cloud/language/samples/AnalyzeIT.java +++ b/language/analysis/src/test/java/com/google/cloud/language/samples/AnalyzeIT.java @@ -59,10 +59,10 @@ public class AnalyzeIT { @Test public void analyzeSentiment_returnPositive() throws Exception { // Act - Sentiment sentiment = + Sentiment sentiment = analyzeApp.analyzeSentiment( "Tom Cruise is one of the finest actors in hollywood and a great star!"); - + // Assert assertThat((double)sentiment.getMagnitude()).isGreaterThan(0.0); assertThat((double)sentiment.getPolarity()).isGreaterThan(0.0); @@ -72,7 +72,7 @@ public class AnalyzeIT { // Act Sentiment sentiment = analyzeApp.analyzeSentiment( - "John was seriously injured in an accident"); + "You are an idiot suck face and I hope you choke on your jolly rancher."); // Assert assertThat((double)sentiment.getMagnitude()).isGreaterThan(0.0); @@ -89,7 +89,7 @@ public class AnalyzeIT { .collect(Collectors.toList()); // Assert - assertThat(got).containsExactly("NOUN", "NOUN", "VERB", + assertThat(got).containsExactly("NOUN", "NOUN", "VERB", "VERB", "ADP", "DET", "ADJ", "NOUN").inOrder(); } } From 38928052ef273e4e3fda9d93e109e2b645908f6d Mon Sep 17 00:00:00 2001 From: Jerjou Cheng Date: Mon, 24 Oct 2016 13:43:01 -0700 Subject: [PATCH 2/2] The NL api was clearly trained in high society, rather than in schoolyard playgrounds after class. --- .../test/java/com/google/cloud/language/samples/AnalyzeIT.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/language/analysis/src/test/java/com/google/cloud/language/samples/AnalyzeIT.java b/language/analysis/src/test/java/com/google/cloud/language/samples/AnalyzeIT.java index 737c4b197d0..59a6bb9cd67 100644 --- a/language/analysis/src/test/java/com/google/cloud/language/samples/AnalyzeIT.java +++ b/language/analysis/src/test/java/com/google/cloud/language/samples/AnalyzeIT.java @@ -72,7 +72,7 @@ public class AnalyzeIT { // Act Sentiment sentiment = analyzeApp.analyzeSentiment( - "You are an idiot suck face and I hope you choke on your jolly rancher."); + "That was the worst performance I've seen in awhile."); // Assert assertThat((double)sentiment.getMagnitude()).isGreaterThan(0.0);