Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datastore: Expose entity identification functions. #2645

Merged
merged 2 commits into from
Oct 10, 2017
Merged

datastore: Expose entity identification functions. #2645

merged 2 commits into from
Oct 10, 2017

Conversation

beaulac
Copy link
Contributor

@beaulac beaulac commented Oct 2, 2017

Closes #2503

Adds functionality to check if values are datastore object types (Int, Double, GeoPoint, and Key).

4 new methods are added to datastore namespace and prototype:

  • isInt
  • isDouble
  • isGeoPoint
  • isKey

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 2, 2017
@beaulac beaulac force-pushed the feature/datastore-entity-identification branch from 57ea569 to f9b8f4a Compare October 3, 2017 23:38
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f9b8f4a on beaulac:feature/datastore-entity-identification into c48d27f on GoogleCloudPlatform:master.

stephenplusplus
stephenplusplus reviewed Oct 10, 2017
View reviewed changes
packages/datastore/src/index.js Outdated
* datastore.isDouble(0.42); // false
* datastore.isDouble(datastore.double(0.42)); // true
*/
Datastore.prototype.isDouble = Datastore.isDouble = function(something) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@stephenplusplus stephenplusplus added the api: datastore Issues related to the Datastore API. label Oct 10, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0c285a3 on beaulac:feature/datastore-entity-identification into c48d27f on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus merged commit 9ecca41 into googleapis:master Oct 10, 2017
@stephenplusplus
Copy link
Contributor

Thank you!

@renovate renovate bot mentioned this pull request Feb 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenplusplus stephenplusplus stephenplusplus left review comments

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@beaulac @coveralls @stephenplusplus @googlebot