Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bigtable data client comment update #3833

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Bigtable data client comment update #3833

merged 2 commits into from
Oct 23, 2018

Conversation

elisheva-qlogic
Copy link
Contributor

Fixes #3815
Updated comments in:
BigtableInstanceAdminClient
BigtableTableAdminClient
BigtableDataClient

@elisheva-qlogic elisheva-qlogic requested a review from a team as a code owner October 18, 2018 19:23
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 18, 2018
igorbernstein2
igorbernstein2 reviewed Oct 19, 2018
View reviewed changes
Copy link

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up. LGTM, but please remove the exists() code

...igtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java Outdated
}
}, MoreExecutors.directExecutor());
}

This comment was marked as spam.

Sign in to view

@elisheva-qlogic elisheva-qlogic force-pushed the BigtableDataClient_comment_update branch from 9e04a1e to 2863e50 Compare October 22, 2018 14:49
@sduskis sduskis added the api: bigtable Issues related to the Bigtable API. label Oct 22, 2018
@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 23, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 23, 2018
@igorbernstein2 igorbernstein2 merged commit 64c0ee6 into googleapis:master Oct 23, 2018
@JesseLovelace JesseLovelace mentioned this pull request Oct 25, 2018
Merged
@elisheva-qlogic elisheva-qlogic deleted the BigtableDataClient_comment_update branch November 8, 2018 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sduskis sduskis sduskis approved these changes

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elisheva-qlogic @sduskis @igorbernstein2 @googlebot @kokoro-team