From abcf1c11614e9da8f920d1809993db18cd4b965d Mon Sep 17 00:00:00 2001
From: QP Hou <qph@scribd.com>
Date: Mon, 7 Sep 2020 15:07:51 -0700
Subject: [PATCH] fix task instance modal open performance issue (#10764)

This reduces the task instance modal open wait time for large DAGs with
extra links from minutes to 6 ms, an order of 10000 times speed up.

GitOrigin-RevId: 3a4f51775f014d218e87bddeebc73172ec1a7d63
---
 airflow/www/templates/airflow/dag.html | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/airflow/www/templates/airflow/dag.html b/airflow/www/templates/airflow/dag.html
index 91eaa8fded3..bc03cae0a94 100644
--- a/airflow/www/templates/airflow/dag.html
+++ b/airflow/www/templates/airflow/dag.html
@@ -478,7 +478,7 @@ <h4 class="modal-title" id="dagModalLabel">
                   "&dag_id=" + encodeURIComponent(dag_id) +
                   "&execution_date=" + encodeURIComponent(execution_date) +
                   "&link_name=" + encodeURIComponent(link);
-          var external_link = $('<a href="#" data-toggle="tooltip" class="btn btn-primary disabled" target="_blank"></a>')
+          var external_link = $('<a href="#" class="btn btn-primary disabled" target="_blank"></a>')
           var link_tooltip = $('<span class="tool-tip" data-toggle="tooltip" style="padding-right: 2px; padding-left: 3px" data-placement="top" ' +
             'title="link not yet available"></span>');
           link_tooltip.append(external_link)
@@ -500,9 +500,10 @@ <h4 class="modal-title" id="dagModalLabel">
           markupArr.push(link_tooltip)
         });
 
-        $('#extra_links').prev('hr').show();
-        $('#extra_links').append(markupArr).show();
-        $('[data-toggle="tooltip"]').tooltip();
+        var extra_links_span = $('#extra_links');
+        extra_links_span.prev('hr').show();
+        extra_links_span.append(markupArr).show();
+        extra_links_span.find('[data-toggle="tooltip"]').tooltip();
       }
     }