-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distributed tracing support in gRPC #436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (with nit), still need to sort out the failing test associated with metadata ordering in argument array.
@@ -442,6 +470,12 @@ module.exports = [ | |||
unpatch: unpatchClient | |||
}, | |||
{ | |||
file: 'src/node/src/metadata.js', | |||
versions: SUPPORTED_VERSIONS, | |||
patch: patchMetadata, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@matthewloring Once tests pass could you take a look at 80888a6? It addresses the previously failing tests. |
CI failure is due to our MySQL tracing tests failing on Node v7.7.2. I can reproduce this locally with v7.7.2 but not v7.7.1, indicating that it arose as a result of the new version of Node being released. We should fix this in a separate PR. |
LGTM given failures unrelated. |
Fix for #434. This changes the gRPC plugin to add the
'x-cloud-trace-context'
metadata field to outgoing gRPC requests, and read it from incoming gRPC requests.