Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve redis code coverage #422

Merged
merged 1 commit into from
Feb 28, 2017
Merged

Improve redis code coverage #422

merged 1 commit into from
Feb 28, 2017

Conversation

matthewloring
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 27, 2017
ofrobots
ofrobots approved these changes Feb 27, 2017
View reviewed changes
Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ nit that it would be good to add a comment about why we have separate tests for 2.3 vs. 2.4 vs latest 2.x.

@matthewloring matthewloring merged commit f17bd67 into googleapis:master Feb 28, 2017
@matthewloring matthewloring deleted the redis branch February 28, 2017 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrobots ofrobots ofrobots approved these changes

@kjin kjin Awaiting requested review from kjin

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewloring @ofrobots @googlebot