Plugins with falsey paths don't get loaded #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjin
requested review from
ofrobots,
matthewloring,
cristiancavalli and
DominicKramer
googlebot
added
the
cla: yes
|
I'm fine with this as long as there is documentation and testing of this behavior. |
kjin
force-pushed
the
propose-falsey-plugin-paths
branch
from
0edf679
to
2d89bfd
Compare
|
@matthewloring I've added both. |
matthewloring
approved these changes
Feb 24, 2017
config.js
Outdated
| // merged with this one. | ||
| // To disable a plugin in this list, you may override its path with a falsey | ||
| // value. Disabling any of the default plugins may cause unwanted behavior, | ||
| // so use caution. | ||
| // This field is experimental. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
kjin
force-pushed
the
propose-falsey-plugin-paths
branch
from
2d89bfd
to
d16f6d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change seeks to introduce not loading a plugin if its path is falsey.
This would make it possible to stop built-in plugins from loading. While we have previously discussed that we don't necessarily know what use cases we are supporting with this, I can name one now: I want to be able to run per-plugin benchmarks, and it would be really neat to isolate a single plugin at a time.
I think falsey is the best approach here because we know for sure that it's not a valid path.
@GoogleCloudPlatform/node-team PTAL.