Plugins with falsey paths don't get loaded #418
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change seeks to introduce not loading a plugin if its path is falsey.
This would make it possible to stop built-in plugins from loading. While we have previously discussed that we don't necessarily know what use cases we are supporting with this, I can name one now: I want to be able to run per-plugin benchmarks, and it would be really neat to isolate a single plugin at a time.
I think falsey is the best approach here because we know for sure that it's not a valid path.
@GoogleCloudPlatform/node-team PTAL.