Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplifications in test/common #408

Merged
merged 1 commit into from
Feb 22, 2017
Merged

Simplifications in test/common #408

merged 1 commit into from
Feb 22, 2017

Conversation

matthewloring
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 22, 2017
@DominicKramer
Copy link
Contributor

LGTM after the tests pass.

kjin
kjin approved these changes Feb 22, 2017
View reviewed changes
Copy link
Contributor

@kjin kjin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM visually.

@matthewloring matthewloring merged commit f9a4b7b into googleapis:master Feb 22, 2017
@matthewloring matthewloring deleted the writer branch February 22, 2017 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjin kjin kjin approved these changes

@DominicKramer DominicKramer Awaiting requested review from DominicKramer

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthewloring @DominicKramer @kjin @googlebot