-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor public api to match plugin api #393
Conversation
PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM w/ small comments.
src/trace-plugin-interface.js
Outdated
* Creates and returns a new ChildSpan object nested within the root span object | ||
* returned by getRootSpan. If there is no current RootSpan object, this | ||
* function returns null. | ||
* Creates and returns a new ChildSpan object nested within the root span.If |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/trace-plugin-interface.js
Outdated
* @param {object} options An object that specifies options for how the child | ||
* span is created and propogated. | ||
* @returns A new ChildSpan object, or null if there is no active root span. | ||
*/ | ||
PluginAPI.prototype.createChildSpan = function(options) { | ||
var rootSpan = this.getRootSpan(); | ||
var rootSpan = this.getRootSpan_(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
}, | ||
setTransactionName: function() {}, | ||
addTransactionLabel: function() {} | ||
enhancedDatabaseReportingEnabled: function() { return false; }, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM w/ nit/question.
wrap: function(fn) { return fn; }, | ||
wrapEmitter: function(ee) { return ee; }, | ||
constants: constants, | ||
labels: TraceLabels | ||
}; | ||
|
||
/** @private */ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
LGTM |
Fixes #330