Support hapi tracing through the plugin API #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
PTAL |
src/plugins/plugin-hapi.js
Outdated
| res.setHeader(constants.TRACE_CONTEXT_HEADER_NAME, context); | ||
|
|
||
| // wrap end | ||
| res.end = function(chunk, encoding) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
kjin
reviewed
Feb 10, 2017
src/plugins/plugin-hapi.js
Outdated
| var urlParse = require('url').parse; | ||
|
|
||
| var constants = require('../constants.js'); | ||
| var TraceLabels = require('../trace-labels.js'); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/plugins/plugin-hapi.js
Outdated
| }; | ||
| api.runInRootSpan(options, function(transaction) { | ||
| if (!transaction) { | ||
| // TODO: Determine if this message is still needed |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Closed
DominicKramer
force-pushed
the
plugin/support-hapi
branch
3 times, most recently
from
b487aa4
to
88d7ed3
Compare
matthewloring
approved these changes
Feb 16, 2017
kjin
approved these changes
Feb 17, 2017
Previously `constants.js`and `trace-labels.js` were also used.
DominicKramer
force-pushed
the
plugin/support-hapi
branch
from
e8dd755
to
4e3ae53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.