-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Express Trace Plugin #363
Conversation
kjin
commented
Feb 7, 2017
- Add Express Trace Plugin
- Remove Express Hook
Dependent on #366 - PTAL at that first |
@@ -0,0 +1,70 @@ | |||
'use strict'; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good structurally, we'll have to look into the failing tests.
src/plugins/plugin-express.js
Outdated
|
||
module.exports = [ | ||
{ versions: SUPPORTED_VERSIONS, patch: patchModuleRoot } | ||
]; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Test failures are due to us no longer unpatching. So this is blocked on |
8416c51
to
62ab860
Compare
CI failures are due to differences in context propagation in mocha in Node v0.12. This is apparent if we add if (this.isActive() && config.forceNewAgent_) {
agent.stop();
} to the public agent's While the fix is small, I think this may a compelling reason to drop support for v0.12. @ofrobots @matthewloring What are your thoughts on this? |
Blocked on #388. |
function middleware(req, res, next) { | ||
var options = { | ||
name: req.path, | ||
traceContext: req.get(api.constants.TRACE_CONTEXT_HEADER_NAME), |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.