Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change connect trace URL prefix and add tests for connect hook #309

Merged
merged 1 commit into from
Oct 3, 2016
Merged

Change connect trace URL prefix and add tests for connect hook #309

merged 1 commit into from
Oct 3, 2016

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Oct 3, 2016

Connect spans now record the protocol and hostname as a prefix to the original URL.

Also, I've added some tests that are pretty similar to the Express ones.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 3, 2016
@kjin
Copy link
Contributor Author

kjin commented Oct 3, 2016

@GoogleCloudPlatform/node-team PTAL

matthewloring
matthewloring approved these changes Oct 3, 2016
View reviewed changes
Copy link
Contributor

@matthewloring matthewloring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cleaning this up! LGTM

@matthewloring
Copy link
Contributor

*LGTM pending travis passing, looks like a few nits.

@kjin kjin merged commit 566309e into googleapis:master Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewloring matthewloring matthewloring approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjin @matthewloring @googlebot