Improve redis code coverage (#422)

PR-URL: #422
googleapis · Feb 28, 2017 · f17bd67 · f17bd67
1 parent 1ea81a5
commit f17bd67
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 1 deletion.
diff --git a/test/plugins/fixtures/redis2.4/index.js b/test/plugins/fixtures/redis2.4/index.js
@@ -0,0 +1 @@
+module.exports = require('redis');
diff --git a/test/plugins/fixtures/redis2.4/package.json b/test/plugins/fixtures/redis2.4/package.json
@@ -0,0 +1,8 @@
+{
+  "name": "redis2.4",
+  "version": "1.0.0",
+  "main": "index.js",
+  "dependencies": {
+    "redis": "2.4.x"
+  }
+}
diff --git a/test/plugins/test-trace-redis.js b/test/plugins/test-trace-redis.js
@@ -28,7 +28,9 @@ var RESULT_SIZE = 5;
 var assert = require('assert');
 var versions = {
   redis0: './fixtures/redis0.12',
+  // Our patches are different on redis <2.3, 2.3 - 2.6, and >2.6
   redis2dot3: './fixtures/redis2.3',
+  redis2dot4: './fixtures/redis2.4',
   redis2dotx: './fixtures/redis2.x',
   redisHiredis04: './fixtures/redis2.3-hiredis0.4',
   redisHiredis05: './fixtures/redis2.3-hiredis0.5'

diff --git a/test/test-unpatch.js b/test/test-unpatch.js
@@ -75,9 +75,24 @@ describe('index.js', function() {
     wrapTest(mongo.Cursor.prototype, 'next');
   });
 
-  it('should wrap/unwrap redis on start/stop', function() {
+  it('should wrap/unwrap redis0.12 on start/stop', function() {
     var redis = require('./plugins/fixtures/redis0.12');
     wrapTest(redis.RedisClient.prototype, 'send_command');
+    wrapTest(redis.RedisClient.prototype, 'install_stream_listeners');
+    wrapTest(redis, 'createClient');
+  });
+
+  it('should wrap/unwrap redis2.4 on start/stop', function() {
+    var redis = require('./plugins/fixtures/redis2.4');
+    wrapTest(redis.RedisClient.prototype, 'send_command');
+    wrapTest(redis.RedisClient.prototype, 'create_stream');
+    wrapTest(redis, 'createClient');
+  });
+
+  it('should wrap/unwrap redis2.x on start/stop', function() {
+    var redis = require('./plugins/fixtures/redis2.x');
+    wrapTest(redis.RedisClient.prototype, 'create_stream');
+    wrapTest(redis.RedisClient.prototype, 'internal_send_command');
     wrapTest(redis, 'createClient');
   });