-
Notifications
You must be signed in to change notification settings - Fork 98
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ensure http response streams are paused (#438)
Responses returned by http#request are yielded in paused mode. By attaching a 'data' listener to the request the http instrumentation was switching the stream to flowing mode which could cause the request to drain before the calling framework had a chance to attach their own listeners. This also removes a test for tracking span duration for http requests with responses that were never checked. We are actually not able to properly close spans in this case without changing the behavior of the requests so this test should not pass. Fixes #437 PR-URL: #438
- Loading branch information
1 parent
72ab677
commit ca4b67b
Showing
2 changed files
with
44 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters