Implement lacking functions in Rust SDK #693
Conversation
|
Build Failed 😱 Build Id: 193007b7-d33e-4900-ae8b-56d76992c5b5 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
There was a problem hiding this comment.
Thanks for submitting this! 🍰
A couple of small things to fix, and this should be good to go.
- I made a note about the feature shortcode below
- If you rebase this against master, what is currently breaking in tests will pass
- Please squash this down to a single commit as per Contributor Guidelines
Once that's done - happy to approve 👍
| @@ -58,3 +53,37 @@ if sdk.shutdown().is_err() { | |||
| println!("Could not run Shutdown"); | |||
| } | |||
| ``` | |||
|
|
|||
| To [set a Label]({{< relref "_index.md#setlabel-key-value" >}}) on the backing `GameServer` call `sdk.set_label(key, value)`. | |||
There was a problem hiding this comment.
Small thing, this will need to be wrapped in a feature shortcode for "0.10.0" so it's hidden until the next release.
For example:
https://agones.dev/site/docs/contribute/#within-a-page
This implements new functions below in Rust SDK and updates related documents and examples.
- SetLabel(key, value)
- SetAnnotation(key, value)
- GameServer()
- WatchGameServer(function(gameserver){...})
thara
force-pushed
the
rust_sdk_improvement
branch
from
bca9542
to
e5722ba
Compare
|
Thanks for your comment. |
|
Build Succeeded 👏 Build Id: 039c5649-45e0-4ccd-8c68-188734161baf The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
markmandel
added
area/user-experience
This implements new functions below in Rust SDK and updates related documents and examples.
I believe this PR make that the Rust SDK have all the SDK functionality.
This PR includes reformatting code by rustfmt.
If it is not acceptable, I would make another one including reformatting code only.