Add Troubleshooting section to Build doc #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victor-prodan
commented
Sep 1, 2018
| @@ -30,7 +30,9 @@ tasks you may wish to accomplish. | |||
| 1. [Build Image Targets](#build-image-targets) | |||
| 1. [Google Cloud Platform](#google-cloud-platform) | |||
| 1. [Minikube](#minikube) | |||
| 1. [Dependencies](#dependencies) | |||
There was a problem hiding this comment.
here I cleaned up some trailing whitespace
|
Build Succeeded 👏 Build Id: d87512c5-32c0-42f6-8725-61bdd47bb494 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
|
Build Succeeded 👏 Build Id: 9a20aa88-4105-4010-ab89-1970e43dbe1f The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
markmandel
reviewed
Sep 1, 2018
build/README.md
Outdated
|
|
||
| Frequent issues and possible solutions | ||
|
|
||
| #### $GOPATH/$GOROOT error when building |
There was a problem hiding this comment.
Do we want to add something specific about how it should be mounted on /c/ -- or that to check if the mount is occuring correctly (with some troubleshooting steps?)
@fooock did you have some suggestions here?
There was a problem hiding this comment.
I would indicate that if the project is on a disk other than c, it would be necessary to mount the disk on which the project is located.
Docker for windows automatically mounts disk c, but if our project is in d, we will have to mount disk d.
There was a problem hiding this comment.
Thanks for the feedback, I'll improve the text.
As long as we're here, is there any other case we should add to troubleshooting?
|
You can see the formatted version here: https://github.com/victor-prodan/agones/tree/master/build |
|
Build Succeeded 👏 Build Id: 60389e1b-3c55-4c4a-b0f7-3a8d0a3af129 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
Build Failed 😱 Build Id: bbcfd4df-af61-4aa1-b6f9-173f44b004a2 Build Logs |
victor-prodan
force-pushed
the
master
branch
from
094b2f8
to
05ff66a
Compare
|
Build Succeeded 👏 Build Id: e36ed7d2-84b3-4288-bbe0-7677650ddfd0 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
victor-prodan
force-pushed
the
master
branch
from
05ff66a
to
84a34a0
Compare
|
CLAs look good, thanks! |
|
Build Failed 😱 Build Id: 582eca4b-521b-47bc-a035-e227d92e8a8e Build Logs |
victor-prodan
force-pushed
the
master
branch
from
84a34a0
to
e6529bb
Compare
|
Build Succeeded 👏 Build Id: 32419d35-6397-4696-99ec-bdedf8a5b1f7 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
markmandel
added
area/build-tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.