Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status > AllocatedReplicas on Fleets & GameServers #196

Merged

Conversation

markmandel
Copy link
Member

Track the number of allocated GameServer replicas on both GameServerSets and Fleets.

This is useful both from a statistical tracking perspective, but also when doing updates to Fleets, as it makes it easy to determine if a GameServerSet can be deleted or not (AllocatedReplicas == 0).

Example:

root@7662dad831f0:/go/src/agones.dev/agones# kubectl describe flt
Name:         simple-udp
Namespace:    default
Labels:       <none>
Annotations:  kubectl.kubernetes.io/last-applied-configuration={"apiVersion":"stable.agones.dev/v1alpha1","kind":"Fleet","metadata":{"annotations":{},"name":"simple-udp","namespace":"default"},"spec":{"replicas":2,...
API Version:  stable.agones.dev/v1alpha1
Kind:         Fleet
Metadata:
  Cluster Name:
  Creation Timestamp:  2018-05-02T19:41:38Z
  Generation:          0
  Resource Version:    214268
  Self Link:           /apis/stable.agones.dev/v1alpha1/namespaces/default/fleets/simple-udp
  UID:                 d4aca215-4e40-11e8-a44a-42010a8a0197
Spec:
  Replicas:  2
  Template:
    Metadata:
      Creation Timestamp:  <nil>
    Spec:
      Container Port:  7654
      Health:
      Template:
        Metadata:
          Creation Timestamp:  <nil>
        Spec:
          Containers:
            Image:  gcr.io/agones-images/udp-server:0.1
            Name:   simple-udp
            Resources:
Status:
  Allocated Replicas:  1 # <=== look here! 😄
  Ready Replicas:      1
  Replicas:            2
Events:
  Type    Reason                 Age   From              Message
  ----    ------                 ----  ----              -------
  Normal  CreatingGameServerSet  13s   fleet-controller  Created GameServerSet simple-udp-qqmjq

Track the number of allocated GameServer replicas
on both GameServerSets and Fleets.

This is useful both from a statistical tracking
perspective, but also when doing updates to Fleets,
as it makes it easy to determine if a GameServerSet
can be deleted or not (AllocatedReplicas == 0).
@markmandel markmandel added the kind/feature New features for Agones label May 2, 2018
@markmandel markmandel added this to the 0.2 milestone May 2, 2018
@markmandel markmandel requested a review from enocom May 2, 2018 19:45
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 57d1afa5-6838-4842-948c-7377ba5f9c40

The following development artifacts have been built, and will exist for the next 30 days:

@markmandel markmandel merged commit d5ad8cc into googleforgames:master May 2, 2018
@markmandel markmandel deleted the feature/allocated-count branch May 2, 2018 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants