Demo doesen't work in firefox

[goleary]

Super useful polyfill & utility functions, thanks!

I tried the demo on Firefox and it does not work:

Env:
Windows 10
Firefox 88.0.1

[tomayac]

@tfmar Any idea what could have caused this? It definitely was working before. There is no error on the console either.

[tomayac]

Both reports were for Firefox 88 (88.0.1). Anything that sticks out in the release notes that looks problematic?

[tomayac]

@sebsg or @SebLalancette, while @tfmar is OoO, are you able to look into this?

[cadeyrn]

Works for me in Firefox ESR 78, Firefox 88 and in Firefox 90 Nightly. It's important that you use the context menu item at least once otherwise the add-on doesn't trigger the permission prompt for the optional permission to access website data. After granting the permission it works.

[goleary]

@cadeyrn Unless I'm missing something this has nothing to do with the extension.

I assumed the polyfill was added to the website itself and therefore did not require using the extension.

[cadeyrn]

Sorry, then I misunderstood. But without extension it doesn't work in Firefox ESR 78 either, so it's not a new issue in Firefox 88.

[guillaumejenkins]

I can repro in FF 88 on Windows 10. Some preliminary debugging shows that init() is never called.

When setting a breakpoint, document.readyState has the value 'interactive', so the code starts listening for the DOMContentLoaded event. Strangely, the event never seems to fire. I have tried setting an event breakpoint on the DOMContentLoaded event, but I never hit it. Perhaps the page is so simple that the event has already fired by the time the breakpoint is applied?

In any case, the issue seems to be that document.readyState isn't what we expect it to be (i.e. 'complete'), but the DOMContentLoaded event has already fired when we start listening to it, so init() is never called.

[ghost]

Simplifying the last few lines to just run init() works fine in my testing.

[tomayac]

Thanks, @guillaumejenkins, for the fix. I have just released v3.3.0 on npm that contains this fix. I let you have a go at #61, and once this is closed, I will release a new version of the Firefox and Safari extensions (which is always a bit of a hassle).