Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export whatwg url interface #38

Closed
wants to merge 2 commits into from

Conversation

mochaaP
Copy link

@mochaaP mochaaP commented Aug 22, 2021

Fixes #33 #34

  • Tests pass
  • Appropriate changes to README are included in PR Not needed as this PR is implementing the same API as Node's

This PR adds exports for WHATWG URL and URLSearchParams interface.

Upstream changes:
nodejs/node@4b31238
nodejs/node@326e967

@google-cla
Copy link

google-cla bot commented Aug 22, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@mochaaP
Copy link
Author

mochaaP commented Aug 22, 2021

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Aug 22, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@mochaaP mochaaP force-pushed the export-whatwg-url branch from 6b694aa to a7dd7d7 Compare August 22, 2021 22:52
@mochaaP
Copy link
Author

mochaaP commented Aug 22, 2021

@googlebot I fixed it.

@mochaaP mochaaP closed this Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript compilation fails for mixed node/web project due to conflict with @types/node "url" module
1 participant